fix(tflint-installer): Scope regex to avoid release json overmatches#997
Open
RoseSecurity wants to merge 1 commit into
Open
fix(tflint-installer): Scope regex to avoid release json overmatches#997RoseSecurity wants to merge 1 commit into
RoseSecurity wants to merge 1 commit into
Conversation
RoseSecurity
requested review from
MaxymVlasov,
antonbabenko and
yermulnik
as code owners
📝 WalkthroughWalkthroughIn Changestflint URL Regex Tightening
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
RoseSecurity
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put an
xinto the box if that apply:Description of your changes
/install/tflint.shby narrowing the TFLint GitHub release URL regex. The previoushttps://.+?...pattern could overmatch GitHub API JSON and pass curl a malformed URL, causing exit code 3. The newhttps://[^\"]*...pattern stops at the JSON string boundary while still matching the linux amd64/arm64 TFLint zip assets.How can we test changes
docker build \ --build-arg INSTALL_ALL=true \ --platform linux/amd64 \ -t pre-commit-terraform:tflint-fix-test .